Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to python 3.11.6 #18482

Closed
wants to merge 8 commits into from
Closed

chore: update to python 3.11.6 #18482

wants to merge 8 commits into from

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Nov 8, 2023 •
edited
Loading

Now that we've updated Celery to version 5

We can update Python to 3.11

Tested by running

deactivate
rm -rf env
pyenv install 3.11.6
pyenv local 3.11.6
python3 -m venv env
source env/bin/activate
pip install --upgrade pip
pip install pip-tools
pip-compile --rebuild requirements.in && pip-compile --rebuild requirements-dev.in 
CFLAGS="-I /opt/homebrew/opt/openssl/include $(python3.11-config --includes)" LDFLAGS="-L /opt/homebrew/opt/openssl/lib" GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1 GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1 pip install -r requirements.txt
pip install -r requirements.txt -r requirements-dev.txt

and then starting locally as usual

TO-DO

  • Validate Django migrations doesn't run because it installs master requirements in order to run its migrations but they can't install here
  • tests are actually failing because the ClickHouse driver bump is breaking something

@frankh frankh closed this Nov 8, 2023
@frankh frankh reopened this Nov 8, 2023
@pauldambra
Copy link
Member

I got bogged down in other work... I'm 90% sure we need to upgrade the ClickHouse driver before we can do this upgrade.

I was thinking of doing that separately in the hope that if it breaks things it's clearer what broke what 🙈

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankh @pauldambra @posthog-bot